Re: [PATCH 2/5] ASoC: dt-bindings: qcom,sm8250: Add QCS6490 RubikPi3 sound card

[Dmitry Baryshkov]

On Mon, Jun 08, 2026 at 10:35:54AM +0800, Hongyang Zhao wrote:
> > On Sun, Jun 07, 2026 at 02:58:18AM +0800, Hongyang Zhao wrote:
> > > Add the thundercomm,qcs6490-rubikpi3-sndcard compatible for the QCS6490
> > > Thundercomm RubikPi3 sound card.
> > > 
> > > Signed-off-by: Hongyang Zhao <hongyang.zhao@xxxxxxxxxxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> > > index 15f38622b98b..d95e072fab25 100644
> > > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> > > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> > > @@ -48,6 +48,7 @@ properties:
> > >            - qcom,sm8250-sndcard
> > >            - qcom,sm8450-sndcard
> > >            - qcom,x1e80100-sndcard
> > > +          - thundercomm,qcs6490-rubikpi3-sndcard
> > 
> > Would it be better to follow the newer pattern and define one compat for
> > all Kodiak platforms? Or would it be possible to use any other QCM6490 /
> > QCS6490 card as a compat fallback?
> > 
> 
> Thanks for your review. I think my commit message did not explain the
> reason clearly enough.
> 
> The RubikPi3 compatible is intended to select board-specific machine
> driver data from the sc8280xp OF match table (added in patch 4/5 of
> this series). RubikPi3 needs different configuration from the existing
> QCM6490/QCS6490 sound cards, including the ES8316 MI2S codec clocking
> and headset jack setup, so using an existing compatible as a fallback
> would select the wrong machine data.

Yes, it should be explained in the commit message.

> 
> > >  
> > >    audio-routing:
> > >      $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > > 
> > > -- 
> > > 2.43.0
> 
> --
> Thanks,
> Hongyang

-- 
With best wishes
Dmitry