Re: [PATCH v7 5/8] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 C-PHY init

[Bryan O'Donoghue]

On 05/06/2026 14:14, David Heidelberg via B4 Relay wrote:
>   	case CAMSS_845:
>   		if (c->phy_cfg == V4L2_MBUS_CSI2_CPHY) {
> -			regs->lane_regs = NULL;
> -			regs->lane_array_size = 0;
> +			regs->lane_regs = &lane_regs_sdm845_3ph[0];
> +			regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845_3ph);
>   		} else {
>   			regs->lane_regs = &lane_regs_sdm845[0];
>   			regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845);
>   		}

The nittiest nit pick I can make sorry ...

IMO the default in the code should be DPHY with CPHY the alternative.

Globally that should be true in this code.

---
bod