Re: [PATCH] platform/x86: dell-laptop: unregister notifier on init failure

[Ilpo Järvinen]

On Wed, 3 Jun 2026, Haoxiang Li wrote:

> Add the missing dell_laptop_unregister_notifier() call to the
> failure path after notifier registration.
> 

Missing a Fixes tag?

> Signed-off-by: Haoxiang Li <lihaoxiang@xxxxxxxxxxxxxxxx>
> ---
>  drivers/platform/x86/dell/dell-laptop.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c
> index 57748c3ea24f..5dd607e8d2ab 100644
> --- a/drivers/platform/x86/dell/dell-laptop.c
> +++ b/drivers/platform/x86/dell/dell-laptop.c
> @@ -2551,6 +2551,7 @@ static int __init dell_init(void)
>  	if (mute_led_registered)
>  		led_classdev_unregister(&mute_led_cdev);
>  fail_led:
> +	dell_laptop_unregister_notifier(&dell_laptop_notifier);

Unfortunately, this doesn't look like to be the only problem here.

>  	dell_battery_exit();
>  	dell_cleanup_rfkill();
>  fail_rfkill:
> 

-- 
 i.