Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
From: Krzysztof Kozlowski
Date: Mon Jun 08 2026 - 08:30:28 EST
On 08/06/2026 14:15, Biju Das wrote:
> Hi Krzysztof Kozlowski,
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> Sent: 08 June 2026 13:12
>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
>>
>> On 08/06/2026 13:59, Biju Das wrote:
>>> Hi Krzysztof Kozlowski,
>>>
>>>> -----Original Message-----
>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>>>> Sent: 08 June 2026 12:55
>>>> Subject: [PATCH] dt-bindings: mfd: syscon: Revert
>>>> renesas,r9a08g046-lvds-cmn
>>>>
>>>> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
>>>> LVDS_CMN syscon for the RZ/G3L") because it is completely not
>>>> matching reality and clearly incorrect in respect of renesas,r9a08g046- lvds-cmn.
>>>>
>>>> It wasn't ever build-tested by author on their DTS, either.
>>>
>>> You are wrong here.
>>>
>>> It is tested with below DTS,
>>
>> Sure, I believe you. Binding is still obviously wrong and does not match the DTS at all.
>
> You are not actually pointing to the mistake in the bindings. It is reviewed by Conor.
I described it very clear in the part of the msg YOU REMOVED.
Does not matter if it was reviewed by Conor. The patch looked correct
for our eyes when looking ALONE at this patch, I also would not spot the
issue. You as the author have the complete picture and you should see
that it is completely bogus combination of compatibles.
Best regards,
Krzysztof