Re: [PATCH 0/2] Add support for IPQ9650 CDSP remoteproc
From: Vignesh Viswanathan
Date: Tue Jun 09 2026 - 01:31:38 EST
On 6/9/2026 8:29 AM, Bjorn Andersson wrote:
> On Wed, May 20, 2026 at 12:56:16AM +0530, Vignesh Viswanathan wrote:
>> Add changes to enable IPQ9650 CDSP. This series adds new Devicetree
>> bindings for IPQ9650 PAS and also adds required changes in qcom_q6v5_pas
>> driver to support IPQ9650 CDSP remoteproc.
>>
>> This series depends on [1], [2] and [3] to functionally bring up the CDSP
>> remoteproc on IPQ9650, but does not contain any compilation dependencies.
>>
>> [1] https://lore.kernel.org/linux-arm-msm/20260518072856.22790-1-sumit.garg@xxxxxxxxxx/
>
> I'm not able to determine why this is a dependency from cover letter,
> commit messages, or the patches. If you have a dependency on this series
> this isn't your typical PAS-based subsystem, so describing what it is in
> the cover letter would be wonderful.
Ack, will describe it better in the next version.
>
>> [2] https://lore.kernel.org/linux-arm-msm/20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@xxxxxxxxxxxxxxxx/T/#t
>> [3] https://lore.kernel.org/linux-arm-msm/20260520-cdsp-power-v1-0-85eb9501a1cd@xxxxxxxxxxxxxxxx/T/#t
>
> #3 is a fundamental part of the addition of this remoteproc driver and
> the solution would be better reviewed as a whole - so you should send
> the two parts in the same series.
Sure, as mentioned in the cdsp power thread, I'll make this a separate
driver instead of adding it to the standard PAS driver.
>
> PS. If you run "git log --oneline" you will see that there shouldn't be
> a "drivers:" prefix in your subject.
Ack.
Thanks,
Vignesh
>
> Regards,
> Bjorn
>
>>
>> ---
>> Vignesh Viswanathan (2):
>> dt-bindings: remoteproc: Document IPQ9650 Compute DSP
>> drivers: remoteproc: qcom_q6v5_pas: Add support for IPQ9650 CDSP
>>
>> .../bindings/remoteproc/qcom,ipq9650-pas.yaml | 136 +++++++++++++++++++++
>> drivers/remoteproc/qcom_q6v5_pas.c | 38 +++++-
>> 2 files changed, 172 insertions(+), 2 deletions(-)
>> ---
>> base-commit: 6a50ba100ace43f43c87384367eb2d2605fcc16c
>> change-id: 20260520-ipq9650-remoteproc-9aa8c6d05de3
>>
>> Best regards,
>> --
>> Vignesh Viswanathan <vignesh.viswanathan@xxxxxxxxxxxxxxxx>
>>