Re: [PATCH v4 0/2] mm: improve folio refcount scalability
From: David Hildenbrand (Arm)
Date: Tue Jun 09 2026 - 06:35:41 EST
On 6/9/26 00:47, Andrew Morton wrote:
> On Mon, 08 Jun 2026 21:53:01 +0000 "Gladyshev Ilya" <ilya.gladyshev@xxxxxxxxx> wrote:
>
>> This patch optimizes small file read performance and overall folio refcount
>> scalability by refactoring page_ref_add_unless [core of folio_try_get].
>> This is alternative approach to previous attempts to fix small read
>> performance by avoiding refcount bumps [1][2].
>
> Thanks. Nice numbers.
>
> AI review had some things to say:
> https://sashiko.dev/#/patchset/df26082871b4c65b2bd38d409026237c08572836@xxxxxxxxx
>
> I'm not sure we want all those new VM_BUG_ON_PAGE() calls in the long
> term. They look like development-time assistance.
VM_WARN_ON_ONCE_PAGE is usually more than sufficient to catch stuff early during
testing.
--
Cheers,
David