Re: [PATCH v1] Bluetooth: qca: Add BT FW build version log

[Paul Menzel]

Dear Xiuzhuo, dear Bartosz


Am 09.06.26 um 11:39 schrieb Bartosz Golaszewski:
> On Tue, 9 Jun 2026 09:54:17 +0200, Xiuzhuo Shang said:
> > Printf BT FW build version log after BT FW downloaded.

Please paste the new lines, so reviewers see how it is going to look 
like. Please also document a motivation (answering Why?).

> > Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/bluetooth/btqca.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> > index dda76365726f..04ebe290bc78 100644
> > --- a/drivers/bluetooth/btqca.c
> > +++ b/drivers/bluetooth/btqca.c
> > @@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
> >
> >   	hci_set_fw_info(hdev, "%s", build_label);
> >
> > +	bt_dev_info(hdev, "QCA FW build version: %s", build_label);
> > +
> >   	kfree(build_label);
> >   out:
> >   	kfree_skb(skb);
>
> This string can be read from debugfs, do we need an additional message in the
> kernel log?

In my opinion the firmware version should be part of the Linux logs, as 
that is what users share with bug reports, and you do not want to have 
several cycles collecting information. For example, currently for 
QCA6174 it’s currently:

    Bluetooth: hci0: QCA: patch rome 0x302 build 0x3e8, firmware rome 
0x302 build 0x111


Kind regards,

Paul


PS:

```
$ sudo dmesg | grep -e ath10k -e Bluetooth
[   17.880668] ath10k_pci 0000:3a:00.0: enabling device (0000 -> 0002)
[   17.883428] ath10k_pci 0000:3a:00.0: pci irq msi oper_irq_mode 2 
irq_mode 0 reset_mode 0
[   18.138972] ath10k_pci 0000:3a:00.0: qca6174 hw3.2 target 0x05030000 
chip_id 0x00340aff sub 1a56:1535
[   18.138977] ath10k_pci 0000:3a:00.0: kconfig debug 1 debugfs 1 
tracing 1 dfs 0 testmode 0
[   18.139068] ath10k_pci 0000:3a:00.0: firmware ver 
WLAN.RM.4.4.1-00309- api 6 features wowlan,ignore-otp,mfp crc32 0793bcf2
[   18.206593] ath10k_pci 0000:3a:00.0: board_file api 2 bmi_id N/A 
crc32 d2863f91
[   18.221145] Bluetooth: Core ver 2.22
[   18.221802] Bluetooth: HCI device and connection manager initialized
[   18.221807] Bluetooth: HCI socket layer initialized
[   18.221808] Bluetooth: L2CAP socket layer initialized
[   18.221813] Bluetooth: SCO socket layer initialized
[   18.258187] Bluetooth: hci0: using rampatch file: 
qca/rampatch_usb_00000302.bin
[   18.258192] Bluetooth: hci0: QCA: patch rome 0x302 build 0x3e8, 
firmware rome 0x302 build 0x111
[   18.301557] ath10k_pci 0000:3a:00.0: htt-ver 3.87 wmi-op 4 htt-op 3 
cal otp max-sta 32 raw 0 hwcrypto 1
[   18.381567] ath10k_pci 0000:3a:00.0 wlp58s0: renamed from wlan0
[   18.619003] Bluetooth: hci0: using NVM file: qca/nvm_usb_00000302.bin
[   18.643646] Bluetooth: hci0: HCI Enhanced Setup Synchronous 
Connection command is advertised, but not supported.
```