Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp-x13s: Use predefined MCLK pinctrl

[Konrad Dybcio]

On 6/7/26 6:04 PM, Pengyu Luo wrote:
> Now that the predefined MCLK pinctrl configuration is available in the
> sc8280xp SoC DTSI, switch the ThinkPad X13s to use it. Drop the local,
> duplicate MCLK pin definition from the camera pinctrl node.
> 
> Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>
> ---
>  .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index abd9c5a67b9f..5d652be69e44 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -674,8 +674,9 @@ camera@10 {
>  		reg = <0x10>;
>  
>  		reset-gpios = <&tlmm 15 GPIO_ACTIVE_LOW>;
> +
> +		pinctrl-0 = <&cam_rgb_default>, <&cam_mclk3_default>;
>  		pinctrl-names = "default";
> -		pinctrl-0 = <&cam_rgb_default>;
>  
>  		leds = <&privacy_led>;
>  		led-names = "privacy";
> @@ -1552,13 +1553,6 @@ cam_indicator_en: cam-indicator-en-state {
>  	};
>  
>  	cam_rgb_default: cam-rgb-default-state {
> -		mclk-pins {
> -			pins = "gpio17";
> -			function = "cam_mclk";
> -			drive-strength = <16>;

This changes the value of drive-strength (which is probably way too
high, but it would be good to know what Lenovo set originally..)

Konrad