Re: [PATCH] i2c: qcom-geni: Use pm_runtime_force_{suspend,resume} helpers
From: Andi Shyti
Date: Tue Jun 09 2026 - 14:30:27 EST
Hi Praveen,
On Wed, May 20, 2026 at 12:44:29PM +0530, Praveen Talari wrote:
> The driver carries custom system suspend/resume handling that manually
> tracks a suspended state and conditionally calls
> geni_i2c_runtime_suspend()
> from the noirq suspend path, then adjusts runtime PM state by hand. This
> duplicates PM core behavior and adds unnecessary complexity.
>
> Drop the manual state tracking and switch to pm_runtime_force_suspend()
> and pm_runtime_force_resume() for system sleep. These helpers already
> perform the required checks, call the runtime PM callbacks when needed,
> and keep runtime PM state transitions consistent.
>
> Reviewed-by: Mukesh Kumar Savaliya <mukesh.savaliya@xxxxxxxxxxxxxxxx>
> Signed-off-by: Praveen Talari <praveen.talari@xxxxxxxxxxxxxxxx>
I normally don't take these patches: Where and when has the
review happened? The reviews has to be done in the mailing list
and I need to be sure that they have been discussed.
But, because I know Mukesh, because this patch has been sitting
for a while and because it looks good to me, I merged it in
i2c/i2c-host. But please, next time I want to see the review
process happening in the mailing list.
Thanks,
Andi