RE: [PATCH rdma-next v3 1/1] RDMA/mana_ib: UC QP support for UAPI

[Long Li]

> Subject: RE: [PATCH rdma-next v3 1/1] RDMA/mana_ib: UC QP support for
> UAPI
> 
> > > +int mana_ib_gd_destroy_rnic_qp(struct mana_ib_dev *mdev, struct
> > > +mana_ib_qp *qp)
> >
> > The function is renamed to _rnic_ to be shared between RC and UC, but
> > the request/response structs are still named _rc_. Should these be
> > renamed to _rnic_ as well for consistency? Or does the firmware use
> > the same destroy command for both QP types?
> 
> Sure, they can be renamed. In the firmware, it is still called RC though, but it
> can be used for all QP types (even UD). So, the name _rc_ is just historical.
> 
> Long, do you want me to rename it?

Yes, it's better to rename them to avoid confusions.

Thanks,
Long