Re: [PATCH] comedi: comedi_test: avoid AI scan timing overflow

From: Samuel Moelius

Date: Tue Jun 09 2026 - 20:00:28 EST


On Tue, Jun 9, 2026 at 6:29 AM Ian Abbott <abbotti@xxxxxxxxx> wrote:
>
> On 09/06/2026 01:14, Samuel Moelius wrote:
> > `waveform_ai_cmdtest()` tries to keep timer-driven analog-input scans
> > representable by limiting `convert_arg` and by making `scan_begin_arg`
> > at least `convert_arg * scan_end_arg`.
> >
> > The conversion clamp tested `scan_begin_arg == TRIG_TIMER` instead of
> > `scan_begin_src == TRIG_TIMER`, so normal timer scans skipped the clamp.
>
> That was fixed in commit 8a3bee801d42 ("comedi: comedi_test: Fix
> limiting of convert_arg in waveform_ai_cmdtest()").

With a more recent commit (2d3090a8aeb5), I can no longer trigger this
bug, so I am withdrawing this patch.

Thank you for the review.