Re: [net-next v1 1/6] dt-bindings: net: dwmac: Add snps,use-ncsi property

[Krzysztof Kozlowski]

On 10/06/2026 09:24, Minda Chen wrote:
> Add snps,use-ncsi dts bindings property for Synopsys designware
> ethernet MAC with RMII interface and used as sideband interface
> network controller(NCSI).

Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch -vX` helps here to create proper versioned
patches. Another useful tool is b4. Skipping the PATCH keyword makes
filtering of emails more difficult thus making the review process less
convenient.

> 
> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2449311c6d28..05b1d8428f65 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -545,6 +545,13 @@ properties:
>        Enables the TSO feature otherwise it will be managed by MAC HW capability
>        register.
>  
> +  snps,use-ncsi:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Use the NC-SI stack instead of an MDIO PHY. Currently assumes

You described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.

Best regards,
Krzysztof