Re: [PATCH v2] platform/x86: intel-hid: Add HP ProBook x360 440 G1 to button_array_table

[Hans de Goede]

Hi,

On 9-Jun-26 23:33, Nikolay Metchev wrote:
> The volume rocker buttons on the HP ProBook x360 440 G1 convertible emit
> events 0xc4-0xc7 via the intel-hid ACPI device (INT33D5). These codes are
> only present in intel_array_keymap, which is used when the "5 button
> array" input device exists. On this machine button_array_present()
> returns false because the firmware does not advertise the array through
> the HEBC method, so notify_handler() routes the events to a NULL
> priv->array and they are dropped as "unknown event 0xc4". As a result
> the side volume keys do nothing.
> 
> Add the machine to button_array_table so the array device is created and
> the volume rocker emits KEY_VOLUMEUP / KEY_VOLUMEDOWN. This is equivalent
> to booting with the enable_5_button_array=1 module parameter, which was
> used to confirm the fix on the affected hardware.
> 
> Signed-off-by: Nikolay Metchev <nikolaymetchev@xxxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@xxxxxxxxxxxxxxxx>

Regards,

Hans



> ---
> Changes since v1:
> - Resend the patch inline instead of as an attachment, as requested.
> - No code changes.
> 
>  drivers/platform/x86/intel/hid.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 085093506..73874d436 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -156,6 +156,13 @@ static const struct dmi_system_id button_array_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 4"),
>  		},
>  	},
> +	{
> +		.ident = "HP ProBook x360 440 G1",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook x360 440 G1"),
> +		},
> +	},
>  	{ }
>  };
>