Re: [PATCH v1 3/3] ASoC: qcom: qdsp6: generalize GPR service domain

[Krzysztof Kozlowski]

On Tue, Jun 09, 2026 at 12:10:38PM +0530, Ajay Kumar Nandam wrote:
> diff --git a/sound/soc/qcom/qdsp6/q6prm.c b/sound/soc/qcom/qdsp6/q6prm.c
> index 04892fb4423f..15ca51ce33b8 100644
> --- a/sound/soc/qcom/qdsp6/q6prm.c
> +++ b/sound/soc/qcom/qdsp6/q6prm.c
> @@ -71,8 +71,9 @@ static int q6prm_set_hw_core_req(struct device *dev, uint32_t hw_block_id, bool
>  		rsp_opcode = PRM_CMD_RSP_RELEASE_HW_RSC;
>  	}
>  
> -	struct gpr_pkt *pkt __free(kfree) =
> -		audioreach_alloc_cmd_pkt(sizeof(*req), opcode, 0, gdev->svc.id, GPR_PRM_MODULE_IID);
> +	struct gpr_pkt *pkt __free(kfree) = audioreach_alloc_cmd_pkt(sizeof(*req),
> +					    opcode, 0, gdev->svc.id, GPR_PRM_MODULE_IID,
> +					    audioreach_gpr_dest_domain(gdev));

I don't understand why you are making all these changes - code is not
readable.

>  	if (IS_ERR(pkt))
>  		return PTR_ERR(pkt);
>  
> @@ -112,9 +113,10 @@ static int q6prm_request_lpass_clock(struct device *dev, int clk_id, int clk_att
>  	struct prm_cmd_request_rsc *req;
>  	gpr_device_t *gdev = prm->gdev;
>  
> -	struct gpr_pkt *pkt __free(kfree) =
> -		audioreach_alloc_cmd_pkt(sizeof(*req), PRM_CMD_REQUEST_HW_RSC, 0,
> -					 gdev->svc.id, GPR_PRM_MODULE_IID);
> +	struct gpr_pkt *pkt __free(kfree) = audioreach_alloc_cmd_pkt(sizeof(*req),
> +					    PRM_CMD_REQUEST_HW_RSC, 0, gdev->svc.id,
> +					    GPR_PRM_MODULE_IID,
> +					    audioreach_gpr_dest_domain(gdev));

Best regards,
Krzysztof