Re: [net-next 1/3] dt-bindings: ptp: renesas,rcar-gen4-gptp: Add binding for R-Car Gen4
From: Niklas Söderlund
Date: Wed Jun 10 2026 - 05:23:13 EST
On 2026-06-10 11:01:27 +0200, Krzysztof Kozlowski wrote:
> On 10/06/2026 10:53, Niklas Söderlund wrote:
> > Hi Krzysztof,
> >
> > Thanks for your comments.
> >
> > On 2026-06-10 08:54:06 +0200, Krzysztof Kozlowski wrote:
> >> On 09/06/2026 23:57, Niklas Söderlund wrote:
> >>> Add bindings for the R-Car Gen4 gPTP timer. The timer enables accurate
> >>> synchronization of the clock in the control system. The timer is
> >>> system-wide and used by different Ethernet devices on each Gen4 platform.
> >>
> >> A nit, subject: drop second/last, redundant "binding for". The
> >> "dt-bindings" prefix is already stating that these are bindings.
> >
> > Thanks, will fix.
> >
> >> See also:
> >> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> >
> > Not sure I follow this one, L18 reads,
> >
> > "Few subsystems, like ASoC, media, regulators and SPI, expect reverse
> > order of the prefixes::"
> >
> > But 'git log Documentation/devicetree/bindings/ptp/' shows all commits
> > in that directory use the 'dt-bindings: ptp:' prefix.
>
> 5 lines below.
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L23
Ahh, thanks.
>
>
> Best regards,
> Krzysztof
--
Kind Regards,
Niklas Söderlund