Re: Re: [PATCH v7 1/2] dt-bindings: pwm: dwc: Add eswin compatible and resets property

[Xuyang Dong]

> 
> On 09/06/2026 11:31, Xuyang Dong wrote:
> >>>
> >>> EIC7700 use DesignWare IP for PWM controllers. Add ESWIN EIC7700 support
> >>> in snps,dw-apb-timers-pwm2.yaml.
> >>>
> >>> The DesignWare PWM includes separate reset signals dedicated to each clock
> >>> domain:
> >>> The presetn signal resets logic in pclk domain.
> >>> The timer_N_resetn signal resets logic in the timer_N_clk domain.
> >>> The resets are active-low.
> >>>
> >>> The generic snps,dw-apb-timers-pwm2 binding allows one or two optional
> >>
> >> I don't know what is the generic binding, but it does not allow. Open
> >> the file: there are no resets at all, so it does not allow them. Or you
> >> mixed tenses here and you wanted to describe the change?
> >>
> > 
> > Hi Krzysztof,
> > 
> > Thanks for your comments and time.
> > 
> > Regarding snps,dw-apb-timers-pwm2, we previously intended to add the 
> > resets property in the same patch. 
> > However, as you suggested, we will split it into a separate patch.
> 
> I find commit msg still confusing. Please always clearly explain WHY you
> are doing changes.
> 

Hi Krzysztof,

Thanks for your comments.

According to the DesignWare IP for PWM controllers manual, it seems to me 
that Ben's previous submission may have missed the optional resets property.

Therefore, I would like to confirm: should I submit a separate fix patch for
the resets property, or include it as a feature patch in this series?

Best regards,
Xuyang Dong