Re: [PATCH v2 12/12] iio: dac: ad5686: add gain control support
From: Andy Shevchenko
Date: Wed Jun 10 2026 - 06:52:27 EST
On Wed, Jun 10, 2026 at 09:25:25AM +0100, Rodrigo Alencar wrote:
> On 09/06/26 21:15, Andy Shevchenko wrote:
> > On Tue, Jun 09, 2026 at 11:13:07AM +0100, Rodrigo Alencar via B4 Relay wrote:
...
> > > + unsigned short vref_mv;
> >
> > _mV
>
> Renaming would need to be a separate refactoring patch. I'll just keep
> as is and just have the field moved down.
I haven't noticed that it is in the original code. Yeah, in such a case it's
fine as is.
--
With Best Regards,
Andy Shevchenko