Re: [PATCH v2] spi: rzv2h-rspi: Fix SPDR read access width for 16-bit RX

[Geert Uytterhoeven]

On Wed, 10 Jun 2026 at 14:08, Felix Gu <ustc.gu@xxxxxxxxx> wrote:
> The RZ/V2H hardware manual (section 7.5.2.2.1) specifies that read access
> size for the SPI Data Register (SPDR) are fixed at 32 bits. The

is fixed

> RZV2H_RSPI_RX macro for the 16-bit data path used readw(), violating
> this requirement.
>
> Switch to readl() for the 16-bit RX path to conform to the hardware
> specification.
>
> Fixes: 8b61c8919dff ("spi: Add driver for the RZ/V2H(P) RSPI IP")
> Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
> ---
> Changes in v2:
> - Fix comments from Geert.
> - Link to v1: https://patch.msgid.link/20260605-rzv2h-rspi-v1-1-c1d5ed562249@xxxxxxxxx

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds