Re: [PATCH 2/4] dt-bindings: arm: qcom: Add Lenovo Yoga Slim 7x Gen11

[Abel Vesa]

On 26-06-10 14:12:30, Konrad Dybcio wrote:
> On 6/4/26 5:18 PM, Krzysztof Kozlowski wrote:
> > On 04/06/2026 17:13, Rob Clark wrote:
> >> On Thu, Jun 4, 2026 at 8:09 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >>>
> >>> On 04/06/2026 10:06, Konrad Dybcio wrote:
> >>>> The Yoga Slim 7x Gen11 is a Snapdragon X2 Elite-based 14" laptop from
> >>>> Lenovo, featuring an OLED touch panel. Add a compatible for it.
> >>>>
> >>>> According to the spec page [1], there  also exist other variations
> >>>> (based on the Mahua SoC and/or with a different type of display panel),
> >>>> but those are to be described separately
> >>>>
> >>>> [1] https://psref.lenovo.com/Product/Yoga_Slim_7_14Q8Y11?tab=spec
> >>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> >>>> ---
> >>>>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> >>>>  1 file changed, 1 insertion(+)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> >>>> index 50cc18a6ec5eddaf48542b85387c2d430cd4721a..fca3d180489d4cd3eb2726a722f15febe44f03ad 100644
> >>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> >>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> >>>> @@ -68,6 +68,7 @@ properties:
> >>>>
> >>>>        - items:
> >>>>            - enum:
> >>>> +              - lenovo,yoga-slim7x-gen11
> >>>
> >>> I imagine you might want different panel variants, just like T14s has
> >>> LCD and OLED?
> >>
> >> I expect this will be the case.
> > 
> > Then better to prepare for this now, otherwise later you need to change
> > bindings. If unsure what other variants are, then at least make this
> > compatible panel-specific, e.g. lenovo,yoga-slim7x-gen11-oled-foo-bar.
> 
> I took another look at psref [1] and there's only OLED SKUs (today?).
> There are however, two different resolutions available and both can be
> touch/notouch.

If the other SKU doesn't have touch, then you might as well mark now this
one with touch suffix or something like that.

> 
> I don't know what this will entail - if the panels are both samsung, I
> would guesstimate the same driver works for them (and Doug was against
> adding new compatibles [2]).
> 
> There's also different SoCs (which will need another #include in DT to
> override, sorta like hamoa and purwa models; they seem not to be
> available in the store rn, but I'd assume it's fine to just rely on the
> SoC strings in the compatible chain to differentiate them.

I think this can be reworked later on, as long as the dtb name stays the
same.