Re: [PATCH v5 4/5] iio: adc: versal-sysmon: add threshold event support

[Andy Shevchenko]

On Wed, Jun 10, 2026 at 01:10:05PM +0100, Erim, Salih wrote:
> On 09/06/2026 18:54, Andy Shevchenko wrote:
> > On Mon, Jun 08, 2026 at 07:38:00PM +0100, Salih Erim wrote:

...

> > > +     /*
> > > +      * regmap errors are not checked here because the worker and IRQ
> > > +      * handler cannot propagate errors. The MMIO regmap uses fast_io
> > > +      * with direct readl/writel which cannot fail.
> > 
> > OK (but they can fail on HW level to the point of bus errors or so :).
> 
> Accepted. Will add error checks to modify flow on failure
> instead of just documenting why they're absent.

> > > +      */

I put smiley in the reply as I don't think it's practical. MMIO failing on HW
level is sign of something much bigger (usually) than just a random neutrino.

So, it's up to you, if you want to add error handling and skip, for example,
write-back of ISR.

-- 
With Best Regards,
Andy Shevchenko