Re: [PATCH bpf v2] bpf: Run generic devmap egress prog on private skb

[Jakub Kicinski]

On Wed, 10 Jun 2026 12:52:21 +0200 Toke Høiland-Jørgensen wrote:
> > @@ -700,12 +700,22 @@ int dev_map_enqueue_multi(struct xdp_frame *xdpf, struct net_device *dev_rx,
> >  int dev_map_generic_redirect(struct bpf_dtab_netdev *dst, struct sk_buff *skb,
> >  			     const struct bpf_prog *xdp_prog)
> >  {
> > +	struct sk_buff *nskb;  
> 
> nit: this definition could go inside the if statement block below, to
> make it obvious that nskb is not used outside that branch.

Or maybe move the copy inside dev_map_bpf_prog_run_skb() since it only
has one caller and already checks if prog is NULL?