Re: [PATCH v13 17/22] media: i2c: maxim-serdes: add MAX96724 driver

From: Dan Carpenter

Date: Wed Jun 10 2026 - 11:13:31 EST


On Wed, Jun 10, 2026 at 04:42:42PM +0200, Niklas Söderlund wrote:
> Hi,
>
> Thanks for your work.
>
> This patch gives me new compiler warnings, can they be avoided?
>
> .../max96724.c:402 max96724_log_phy_status() warn: subtract is higher precedence than shift
> .../max96724.c:409 max96724_log_phy_status() warn: subtract is higher precedence than shift
> .../max96724.c:588 max96724_init_phy() warn: subtract is higher precedence than shift
> .../max96724.c:756 max96724_set_pipe_remap() warn: subtract is higher precedence than shift
> .../max96724.c:796 max96724_set_pipe_phy() warn: subtract is higher precedence than shift
> .../max96724.c:818 max96724_set_pipe_stream_id() warn: subtract is higher precedence than shift
> .../max96724.c:830 max96724_set_pipe_link() warn: subtract is higher precedence than shift
> .../max96724.c:942 max96724_set_link_version() warn: subtract is higher precedence than shift
>

These are Smatch warnings. I appologize for them. I know about them
but I haven't looked at them. I'll fix them by the end of the week.

regards,
dan carpenter