Re: [PATCH] parport: Consistently define pci_device_ids using named initializers
From: Uwe Kleine-König (The Capable Hub)
Date: Wed Jun 10 2026 - 13:05:26 EST
[adding Greg to Cc: as his tree seems to be the usual way into mainline
for these drivers.]
Hello Sudip,
On Wed, Apr 29, 2026 at 06:14:53PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> ... and PCI device helpers.
>
> The various struct pci_device_id arrays were initialized mostly by list
> expressions. This isn't easily readable if you're not into PCI.
>
> Use PCI_DEVICE* helper macros and named initializers which is more
> explicit and thus easier to parse. Also skip explicit assignments of 0
> (which the compiler then takes care of).
>
> The secret plan is to make struct pci_device_id::driver_data an
> anonymous union (similar to
> https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@xxxxxxxxxxxx/)
> and that requires named initializers. But it's also a nice cleanup on
> its own.
>
> This change doesn't introduce changes to the compiled pci_device_id
> arrays. Tested on x86 and arm64.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
Gentil ping! I'd like to work on the actual change to pci_device_id and
that requires this patch to be in.
Is it already too late for 7.2-rc1?
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature