Re: [PATCH v1] pinctrl: qcom: lpass-lpi: drop unused runtime-PM write helper

[Ajay Kumar Nandam]

On 6/10/2026 2:30 PM, Krzysztof Kozlowski wrote:
> On 10/06/2026 10:57, Ajay Kumar Nandam wrote:
> > > So why do we need __lpi_gpio_write()?
> >
> > Hi Krzysztof,
> >
> > Thanks, good point.
> >
> > I will respin with:
> > Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx>
>
>
> And checkpatch.
>
> > About __lpi_gpio_write(): it is still needed for the in-callers path
> > where runtime PM is already held and we only need the raw MMIO helper.
> > The unused wrapper is lpi_gpio_write(), so this fix removes only that
> > dead function.
>
> No. Why did you have to add __ prefix? Why do we need function named
> with such style?

I’ve posted v2 addressing this:
https://lore.kernel.org/all/20260610180012.3505877-1-ajay.nandam@xxxxxxxxxxxxxxxx/

In v2 I removed the unused wrapper, renamed the internal helpers from 
__lpi_gpio_* to lpi_gpio_*_reg (no functional change)

Thanks
Ajay kumar Nandam

> Best regards,
> Krzysztof