Re: [PATCH v2 2/5] dt-bindings: display: bridge: Document Renesas R-Car V4H DSC bindings

[Laurent Pinchart]

On Fri, May 15, 2026 at 06:32:27PM +0100, Conor Dooley wrote:
> On Fri, May 15, 2026 at 10:56:15AM +0300, Tomi Valkeinen wrote:
> > From: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> > 
> > The Renesas DSC Display Stream Compression is a bridge embedded in the
> > Renesas R-Car V4H SoC. The bridge performs VESA DSC encoding of up to
> > 8k or 400 Mpixel/s .
> > 
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> > [tomi.valkeinen: fix the example]
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/display/bridge/renesas,dsc.yaml       | 96 ++++++++++++++++++++++
> >  1 file changed, 96 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsc.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dsc.yaml
> > new file mode 100644
> > index 000000000000..2918d592732b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsc.yaml
> 
> Filename matching the compatible please.
> 
> pw-bot: changes-requested
> 
> > @@ -0,0 +1,96 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/bridge/renesas,dsc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas R-Car DSC Display Stream Compression
> > +
> > +maintainers:
> > +  - Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> > +
> > +description: |
> > +  This binding describes the VESA DSC Display Stream Compression encoder
> > +  embedded in the Renesas R-Car V4H SoC. The encoder supports all DSC1.1
> > +  encoding mechanisms, configurable bits-per-pixel, resolution up to 8k.
> > +
> > +properties:
> > +  compatible:
> > +    const: renesas,r8a779g0-dsc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port@0:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description: R-Car DU input port
> > +
> > +      port@1:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description: R-Car DSI output port
> > +
> > +    required:
> > +      - port@0
> > +      - port@1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - interrupts
> > +  - power-domains
> > +  - resets
> > +  - ports
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/r8a779g0-cpg-mssr.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/power/r8a779g0-sysc.h>
> > +
> > +    dsc@feb8d000 {
> 
> Speaking of fixing the example, should this not be "decoder" or

Or rather "encoder"

> "bridge"?
> Not a big deal though.
> With the changed filename
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 
> > +        compatible = "renesas,r8a779g0-dsc";
> > +        reg = <0xfeb8d000 0x400>;
> > +        interrupts = <GIC_SPI 559 IRQ_TYPE_LEVEL_HIGH>;
> > +        clocks = <&cpg CPG_MOD 2819>;
> > +        power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> > +        resets = <&cpg 2819>;
> > +
> > +        ports {
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            port@0 {
> > +                reg = <0>;
> > +                dsc_in_dsi1: endpoint {
> > +                    remote-endpoint = <&du_out_dsi1>;
> > +                };
> > +            };
> > +
> > +            port@1 {
> > +                reg = <1>;
> > +                dsc_out_dsi1: endpoint {
> > +                    remote-endpoint = <&dsi1_in>;
> > +                };
> > +            };
> > +        };
> > +    };
> > +...

-- 
Regards,

Laurent Pinchart