Re: [PATCH v3 04/18] firmware: qcom: scm: Add minidump SRAM support

[Konrad Dybcio]

On 5/22/26 9:49 PM, Mukesh Ojha wrote:
> On most Qualcomm SoCs where minidump is supported, a word in always-on
> SRAM is shared between the kernel and boot firmware. Before DDR is
> initialised on the warm reset following a crash, firmware reads this
> word to decide if minidump is enabled and collect a minidump and where
> to deliver it (USB upload to a host, or save to local storage).
> 
> The SRAM region is described by a 'sram' phandle on the SCM DT node.
> If the property is absent the feature is silently disabled, keeping
> existing SoCs unaffected.
> 
> Expose a 'minidump_dest' module parameter (default: usb) so the user can
> select the destination. Only the string names "usb" or "storage" are
> acceptable values.
> 
> Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> ---

[...]


> +	for (i = 0; i < ARRAY_SIZE(minidump_dest_map); i++)
> +		if (sysfs_streq(val, minidump_dest_map[i].name))

I'm not sure about sysfs_streq() specifically, but otherwise this lgtm

Konrad