Re: [PATCH net-next v2 05/15] tcp: allow mptcp to drop TS for some packets

From: Eric Dumazet

Date: Thu Jun 11 2026 - 08:42:16 EST


On Thu, Jun 11, 2026 at 1:49 AM Matthieu Baerts <matttbe@xxxxxxxxxx> wrote:
>
> Hi Paolo, Eric,
>
> On 11/06/2026 09:39, Paolo Abeni wrote:
> > Hi Eric,

> > I'm wondering if you are ok with this patch in the current form?
> >
> > One thing that was discussed on the mptcp ML was exposing the
> > tcp_out_options layout so that mptcp_established_options() could receive
> > such argument and likely clean-up a bit this code.
> >
> > Not done here because placing tcp_out_options under `include` felt a bit
> > "too much". Perhaps adding a `net/ipv4/tcp_option.h` header (and
> > including it from the mptcp code) would be more palatable?
>
> Note that I also didn't do this because that would mean the removal of
> the TCP TS option would be done from the MPTCP side, and not here from
> the TCP side. That didn't feel right to hide this from the MPTCP side.
> But I'm fine to change if preferred.
>

Current patch LGTM, thanks!

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>