Re: [PATCH 2/2] pinctrl: upboard: add device id INTC1055 based UP boards support
From: Andy Shevchenko
Date: Thu Jun 11 2026 - 12:07:22 EST
On Thu, Jun 11, 2026 at 02:29:07PM +0200, Linus Walleij wrote:
> On Wed, Jun 10, 2026 at 11:00 AM GaryWang <is0124@xxxxxxxxx> wrote:
...
> > +static const struct pinctrl_map pinctrl_map_adl[] = {
> > + PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "i2c0_grp", "i2c0"),
> > + PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "i2c1_grp", "i2c1"),
> > + PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "pwm0_grp", "pwm0"),
> > + PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "uart1_grp", "uart1"),
> > + PIN_MAP_MUX_GROUP_DEFAULT("upboard-pinctrl", "INTC1055:00", "ssp2_grp", "ssp2"),
> > +};
>
> This looks very ACPI so I do not dare to merge it unless Andy or Mika ACKs it.
Basically I proposed to merge via Intel pin control tree, in such a case
the Ack will be implicit (as it will have my SoB). But I want you to have
a look from high level point of view of pin control subsystem.
--
With Best Regards,
Andy Shevchenko