Re: [PATCH 1/2] ASoC: SOF: Intel: select SND_SOC_SDW_UTILS=y from SND_SOC_SOF_HDA_GENERIC=y
From: Arnd Bergmann
Date: Thu Jun 11 2026 - 14:22:54 EST
On Thu, Jun 11, 2026, at 16:20, Mark Brown wrote:
> On Thu, Jun 11, 2026 at 03:23:05PM +0200, Arnd Bergmann wrote:
>> +++ b/sound/soc/sof/intel/Kconfig
>> @@ -335,7 +335,7 @@ config SND_SOC_SOF_HDA_GENERIC
>> select SND_INTEL_DSP_CONFIG
>> select SND_SOC_SOF_HDA_LINK_BASELINE
>> select SND_SOC_SOF_HDA_PROBES
>> - select SND_SOC_SDW_UTILS if SND_SOC_SOF_INTEL_SOUNDWIRE
>> + select SND_SOC_SDW_UTILS if SND_SOC_SOF_INTEL_SOUNDWIRE !=n
>
> Can we end up with SND_SOC_SDW_UTILS=y but SOUNDWIRE=m? Though I think
> that's a potential issue anyway...
I don't see that combination in any randconfig builds and haven't
managed to produce it in menuconfig, but I can't swear that it's
impossible either.
I do feel that the entire set of dependencies around
SOUNDWIRE, HDA and the Intel/AMD drivers is too fragile,
so it would be good if someone could manage to simplify this
in some form, but the best I can do at the moment it to
address regressions when they happen.
With the patches that I have sent, plus the "ASoC: amd: acp: Fix
linker error with SDCA quirks" one from Syed Saba Kareem that
I'm testing at the moment, I get no link failures in randconfig
kernels.
Arnd