Re: [PATCH v2 3/3] regulator: qcom-refgen: add support for the IPQ9650 SoC

[Dmitry Baryshkov]

On Thu, Jun 11, 2026 at 02:33:18PM +0530, Kathiravan Thirumoorthy wrote:
> IPQ9650 SoC has 2 REFGEN blocks providing the reference current to the
> PCIe and USB, UNIPHY PHYs. For the other SoCs, clocks for this block is
> enabled on power up but that's not the case for IPQ9650 and we have to
> enable those clocks explicitly to bring up the PHYs properly.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@xxxxxxxxxxxxxxxx>
> ---
>  drivers/regulator/qcom-refgen-regulator.c | 89 +++++++++++++++++++++++++++++--
>  1 file changed, 85 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/regulator/qcom-refgen-regulator.c b/drivers/regulator/qcom-refgen-regulator.c
> index 6a3795469927..e8821f159ff1 100644
> --- a/drivers/regulator/qcom-refgen-regulator.c
> +++ b/drivers/regulator/qcom-refgen-regulator.c
> @@ -3,6 +3,7 @@
>  // Copyright (c) 2023, Linaro Limited
>  
>  #include <linux/bitfield.h>
> +#include <linux/clk.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
> @@ -16,6 +17,10 @@
>   #define REFGEN_BIAS_EN_ENABLE		0x7
>   #define REFGEN_BIAS_EN_DISABLE		0x6
>  
> +#define REFGEN_REG_REFGEN_STATUS	0xC

Lowercase hex, please.

With that fixed:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>



> +#define REFGEN_STATUS_OUT_MASK		BIT(3)
> + #define REFGEN_STATUS_OUT_ENABLE	0x8
> +

-- 
With best wishes
Dmitry