Re: [PATCH v5 0/2] Incorporate DRAM address in EDAC messages

[Borislav Petkov]

On Thu, Jun 11, 2026 at 01:01:07PM -0400, Yazen Ghannam wrote:
> IMO, consider the risk and the outcome.
>
> In this case, the conditions to hit the issue are rare.
> 
> Real DRAM ECC occurs and logged through EDAC: rare
> EDAC_DEBUG config option enabled: almost never
> User is doing a fake_inject: practically 0% chance
> 
> If the issue occurs, what is the outcome?
> 
> The "other_detail" string gets messed up for one of the error logs.
> 
> Of course, if no one is using fake_inject, then removing it closes this
> small risk. I guess that's the point, right?

We don't ever keep broken code in the kernel. No matter how many people can
hit it. I know, I know, but what is the chance?

It doesn't matter. If we know it is broken we either fix it or remove it. And
sometimes fixing it "takes a while" and there are bugs which linger for years
for whatever reason.

But we never leave stuff unfixed because someone might use it, someone might
depend on it and considering how many people are using Linux, you can imagine
that "practically 0% chance" is more than 0 in reality...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette