Re: [PATCH v4 1/3] dt-bindings: hwmon: pmbus: Add bindings for Silergy SQ24860

[Krzysztof Kozlowski]

On Fri, Jun 12, 2026 at 11:03:02AM +0800, Ziming Zhu wrote:
> From: Ziming Zhu <ziming.zhu@xxxxxxxxxxxxxxx>
> 
> Add devicetree binding documentation for the Silergy SQ24860 eFuse.
> 
> The device is a PMBus hardware monitoring device which reports voltage,
> current, power, and temperature telemetry. The board-specific IMON
> resistor value is described with silergy,rimon-micro-ohms.
> 
> Signed-off-by: Ziming Zhu <ziming.zhu@xxxxxxxxxxxxxxx>
> 

Do not add blank lines between tags. I recommend to use b4 to handle
this - it would solve your problems, including the missing tag in
previous version.

> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

> ---
>  .../bindings/hwmon/pmbus/silergy,sq24860.yaml | 74 +++++++++++++++++++
>  1 file changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/silergy,sq24860.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/silergy,sq24860.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/silergy,sq24860.yaml
> new file mode 100644
> index 000000000000..03ef82c11e1a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/silergy,sq24860.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/pmbus/silergy,sq24860.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Silergy SQ24860 eFuse
> +
> +maintainers:
> +  - Ziming Zhu <ziming.zhu@xxxxxxxxxxxxxxx>
> +
> +description:
> +  The Silergy SQ24860 is an integrated, high-current circuit protection and
> +  power management device with PMBus interface.
> +
> +properties:
> +  compatible:
> +    const: silergy,sq24860
> +
> +  reg:
> +    maxItems: 1
> +
> +  silergy,rimon-micro-ohms:

Isn't this just shunt-resistor-micro-ohms? IOW, didn't you just describe
the shunt?

> +    description:
> +      Micro-ohms value of the resistance installed between the IMON pin and
> +      the ground reference.

Best regards,
Krzysztof