RE: [PATCH net-next v3] ixgbe: implement get_queue_stats_rx

[Jagielski, Jedrzej]

From: Kshitiz Bartariya <kshitiz.bartariya@xxxxxxxxxxx> 
Sent: Friday, June 12, 2026 10:46 AM

>Hook into the netdev_stat_ops interface to expose per RX queue
>statistics through the netdev generic netlink API.
>
>The following counters are filled:
> - bytes: maps directly to bytes
> - packets: maps directly to packets
> - alloc_fail: sum of alloc_rx_page_failed and alloc_rx_buff_failed
> - csum_bad: maps directly to csum_err, which is incremented for both
>   IP header and L4 checksum errors in ixgbe_rx_checksum().
>
>The new per-queue stats can be observed with:
>  $ ynltool qstats show scope queue
>
>Signed-off-by: Kshitiz Bartariya <kshitiz.bartariya@xxxxxxxxxxx>
>---
>v3:
> - Added bytes and packets stats counters
> - Implemented ixgbe_get_base_stats function
> As suggested by AI on 
> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260603174857.78666-1-kshitiz.bartariya%40zohomail.in
>
>v2:
> Amended commit message with command to get RX queue stats as 
> suggested by Jedrzej Jagielski.
> https://lore.kernel.org/lkml/20260603174857.78666-1-kshitiz.bartariya@xxxxxxxxxxx/
>
>v1: 
> https://lore.kernel.org/lkml/20260602100932.21838-1-kshitiz.bartariya@xxxxxxxxxxx/
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
>diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>index bc16e4c93fd4..fb15b70e91d9 100644
>--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>@@ -9759,6 +9759,35 @@ static void ixgbe_get_stats64(struct net_device *netdev,
> 	stats->rx_missed_errors	= netdev->stats.rx_missed_errors;
> }
> 
>+static void ixgbe_get_queue_stats_rx(struct net_device *dev, int idx,
>+				     struct netdev_queue_stats_rx *stats)
>+{
>+	struct ixgbe_adapter *adapter = ixgbe_from_netdev(dev);
>+	struct ixgbe_ring *ring = adapter->rx_ring[idx];
>+
>+	stats->bytes = ring->stats.bytes;
>+	stats->packets = ring->stats.packets;
>+	stats->alloc_fail = ring->rx_stats.alloc_rx_page_failed +
>+			    ring->rx_stats.alloc_rx_buff_failed;
>+	stats->csum_bad = ring->rx_stats.csum_err;
>+}
>+
>+static void ixgbe_get_base_stats(struct net_device *dev,
>+				 struct netdev_queue_stats_rx *rx,
>+				 struct netdev_queue_stats_tx *tx)
>+{
>+	// ixgbe has no inactive queues

Hi Kshitiz

that's not the way we are putting comments in the netdev
code - please use /* ... */ even for oneliners

>+	rx->bytes = 0;
>+	rx->packets = 0;
>+	rx->alloc_fail = 0;
>+	rx->csum_bad = 0;
>+}
>+
>+static const struct netdev_stat_ops ixgbe_stat_ops = {
>+	.get_queue_stats_rx = ixgbe_get_queue_stats_rx,
>+	.get_base_stats = ixgbe_get_base_stats,
>+};

please put ixgbe_stat_ops declaration next to the ixgbe_netdev_ops

when both notes applied feel free to add by RB tag

Thanks!

>+
> static int ixgbe_ndo_get_vf_stats(struct net_device *netdev, int vf,
> 				  struct ifla_vf_stats *vf_stats)
> {
>@@ -11662,6 +11691,7 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> 	hw->phy.mdio.mdio_write = ixgbe_mdio_write;
> 
> 	netdev->netdev_ops = &ixgbe_netdev_ops;
>+	netdev->stat_ops   = &ixgbe_stat_ops;
> 	ixgbe_set_ethtool_ops(netdev);
> 	netdev->watchdog_timeo = 5 * HZ;
> 	strscpy(netdev->name, pci_name(pdev), sizeof(netdev->name));
>-- 
>2.50.1 (Apple Git-155)