Re: [RFC PATCH 0/1] vfs: pass S_IFDIR mode to vfs_prepare_mode()

[Christian Brauner]

On Fri, Jun 12, 2026 at 12:33:53PM +0200, Jan Kara wrote:
> On Thu 11-06-26 22:20:40, Jori Koolstra wrote:
> > Hi Jan,
> > 
> > > Op 11-06-2026 17:33 CEST schreef Jan Kara <jack@xxxxxxx>:
> > > 
> > > For the filesystems I know this looks sound. Thanks for the cleanup. But
> > > this series should then follow with the removal of now-pointless "|
> > > S_IFDIR" statements.
> > > 
> > 
> > Right, perhaps it should. But wouldn't that be too much churn? I know Al can
> > really be on the brake sometimes with regards to that. But it isn't a lot of
> > effort, so I am fine with it.
> 
> I agree it will be more churn but leaving the now-pointless | S_IFDIR in
> the filesystems is confusing for code readers which isn't good either. So
> at least for filesystems I maintain I would like that cleanup to be done.

Jan is (as usual) right.