[PATCH 05/12] fs/ceph/super.h: convert ceph_cap_snap.writing fields to `bool`

From: Max Kellermann

Date: Fri Jun 12 2026 - 12:55:10 EST


This will allow better struct packing.

Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx>
---
fs/ceph/caps.c | 2 +-
fs/ceph/snap.c | 4 ++--
fs/ceph/super.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index cf9916608dc2..e50bcb393c8f 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -3288,7 +3288,7 @@ static void __ceph_put_cap_refs(struct ceph_inode_info *ci, int had,
struct ceph_cap_snap,
ci_item);

- capsnap->writing = 0;
+ capsnap->writing = false;
if (ceph_try_drop_cap_snap(ci, capsnap))
/* put the ref held by ceph_queue_cap_snap() */
put++;
diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c
index 52b4c2684f92..6dbc7859ff49 100644
--- a/fs/ceph/snap.c
+++ b/fs/ceph/snap.c
@@ -521,7 +521,7 @@ static bool has_new_snaps(struct ceph_snap_context *o,
* However, if a (sync) write is currently in-progress when we apply
* the snapshot, we have to wait until the write succeeds or fails
* (and a final size/mtime is known). In this case the
- * cap_snap->writing = 1, and is said to be "pending." When the write
+ * cap_snap->writing = true, and is said to be "pending." When the write
* finishes, we __ceph_finish_cap_snap().
*
* Caller must hold snap_rwsem for read (i.e., the realm topology won't
@@ -627,7 +627,7 @@ static void ceph_queue_cap_snap(struct ceph_inode_info *ci,
doutc(cl, "%p %llx.%llx cap_snap %p snapc %p seq %llu used WR,"
" now pending\n", inode, ceph_vinop(inode), capsnap,
old_snapc, old_snapc->seq);
- capsnap->writing = 1;
+ capsnap->writing = true;
} else {
/* note mtime, size NOW. */
__ceph_finish_cap_snap(ci, capsnap);
diff --git a/fs/ceph/super.h b/fs/ceph/super.h
index 18960a9e735a..505a1552f355 100644
--- a/fs/ceph/super.h
+++ b/fs/ceph/super.h
@@ -269,7 +269,7 @@ struct ceph_cap_snap {
u64 time_warp_seq;
u64 truncate_size;
u32 truncate_seq;
- int writing; /* a sync write is still in progress */
+ bool writing; /* a sync write is still in progress */
int dirty_pages; /* dirty pages awaiting writeback */
bool inline_data;
bool need_flush;
--
2.47.3