Re: [PATCH v4 4/4] iio: flow: add Sensirion SLF3S liquid flow sensor driver

From: Jonathan Cameron

Date: Fri Jun 12 2026 - 13:48:58 EST


On Thu, 11 Jun 2026 16:01:12 +0200
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> On 11/06/2026 15:27, Wadim Mueller wrote:
> > +
> > +static const struct of_device_id slf3s_of_match[] = {
> > + { .compatible = "sensirion,slf3s-0600f", .data = &slf3s_variants[0] },
> > + { .compatible = "sensirion,slf3s-1300f", .data = &slf3s_variants[1] },
> > + { .compatible = "sensirion,slf3s-4000b", .data = &slf3s_variants[2] },
>
> You should have only 1300f here and detect the variants. That was my
> point when I suggested to use the fallback.
>

I'm lost. How does that work? They cannot fallback to that part because
it relies on in driver detection of the fact that they are incompatible.

Jonathan


> Best regards,
> Krzysztof