Re: [PATCH net 0/2] octeontx2: quiesce stale mailbox IRQ state before request_irq()

[Simon Horman]

On Fri, Jun 12, 2026 at 12:00:12AM +0800, Runyu Xiao wrote:
> Both OTX2 mailbox registration paths currently install their IRQ
> handlers before clearing stale local mailbox interrupt state, even
> though the code comments already say that the clear is needed first to
> avoid spurious interrupts.
> 
> This issue was found by our static analysis tool and manually audited on
> Linux v6.18.21. Directed QEMU no-device validation further showed that
> the real PF and VF mailbox handlers are already reachable in that
> pre-clear window and can touch the same mailbox and workqueue carrier
> before local quiesce has completed.
> 
> This series keeps the change minimal:
> 
> - clear stale mailbox interrupt state before request_irq()
> - keep interrupt enabling after the handler is installed
> 
> That closes the early-IRQ window without introducing a new
> enable-before-handler window.
> 
> Patch 1 fixes the PF mailbox registration path.
> Patch 2 fixes the VF mailbox registration path.
> 
> Build-tested by compiling otx2_pf.o and otx2_vf.o.
> 
> No OTX2 hardware was available for end-to-end runtime testing.
> 
> Runyu Xiao (2):
>   octeontx2-pf: clear stale mailbox IRQ state before request_irq()
>   octeontx2-vf: clear stale mailbox IRQ state before request_irq()

For the series:

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>