Re: [PATCH] net: pch_gbe: handle TX skb allocation failure

[Paolo Abeni]

On 6/8/26 6:30 PM, Ruoyu Wang wrote:
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> index 62f05f4569b10..a426243a5fa34 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> @@ -1420,13 +1420,23 @@ pch_gbe_alloc_rx_buffers_pool(struct pch_gbe_adapter *adapter,
>  	return 0;
>  }
>  
> +static void pch_gbe_free_rx_buffers_pool(struct pch_gbe_adapter *adapter,
> +					 struct pch_gbe_rx_ring *rx_ring)
> +{
> +	dma_free_coherent(&adapter->pdev->dev, rx_ring->rx_buff_pool_size,
> +			  rx_ring->rx_buff_pool, rx_ring->rx_buff_pool_logic);
> +	rx_ring->rx_buff_pool_logic = 0;
> +	rx_ring->rx_buff_pool_size = 0;
> +	rx_ring->rx_buff_pool = NULL;
> +}
> +
>  /**
>   * pch_gbe_alloc_tx_buffers - Allocate transmit buffers
>   * @adapter:   Board private structure
>   * @tx_ring:   Tx descriptor ring
>   */
> -static void pch_gbe_alloc_tx_buffers(struct pch_gbe_adapter *adapter,
> -					struct pch_gbe_tx_ring *tx_ring)
> +static int pch_gbe_alloc_tx_buffers(struct pch_gbe_adapter *adapter,
> +				    struct pch_gbe_tx_ring *tx_ring)

With this change you should update accordingly the kdoc above
documenting the return value, to avoid this warning:

Warning: drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:1439 No
description found for return value of 'pch_gbe_alloc_tx_buffers'

/P