Re: [net-next 9/9] net: ethernet: ravb: Add gPTP support for Gen4

[Sergey Shtylyov]

On 6/10/26 1:24 PM, Niklas Söderlund wrote:

> While driver advertise gPTP support on Gen4 platforms it is in fact

   Advertises.

> completely broken. On R-Car Gen4 devices the RAVB module have no
> internal gPTP clock as generations before it. Instead it utilizes a
> system wide gPTP clock.
> 
> This change utilizes the refactoring of the RAVB gPTP code to add
> support for a system wide clock and stops the Gen4 devices trying to use

   System-wide?

> the non-existing internal gPTP clock.
> 
> To remain backward compatible the device tree property needed
> (renesas,gptp) to get hold of the system gPTP clock is optional. If the

   Can't parse this statement...

> property is not present, or not enabled, the RAVB driver will no longer
> advertise gPTP support to user-space.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

Reviewed-by: Sergey Shtylyov <sergei.shtylyov@xxxxxxxxx>

[...]

> diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
> index caad95a9c3c5..acdfb56bb135 100644
> --- a/drivers/net/ethernet/renesas/ravb.h
> +++ b/drivers/net/ethernet/renesas/ravb.h
> @@ -249,6 +249,8 @@ enum APSR_BIT {
>  	APSR_RDM	= 0x00002000,
>  	APSR_TDM	= 0x00004000,
>  	APSR_MIISELECT	= 0x01000000,	/* R-Car V4M only */
> +	APSR_GPTPTIMER_SOURCE = BIT(25), /* Gen4 */
> +	APSR_GPTPCLOCK	= BIT(29),	/* Gen4 */

   Hum, the other *enum* entries don't use BIT()...

[...]

MBR, Sergey