Re: [RFC PATCH v4 0/6] samples/damon: handle damon_{start,stop}() failures

[Zenghui Yu]

On 6/10/26 9:55 PM, SeongJae Park wrote:
> All DAMON sample modules are not correctly handling failures from
> damon_start().  Among those, mtier also has an additional problem for
> handling of damon_stop() failures.  wsse and prcl also have a problem in
> their damon_call() failure handling.  As a result, memory leaks, next
> DAMON operation disruptions, and use-after-free can happen.  Fix those.
> 
> Note that only the damon_start() failure caused issues can reliably be
> reproduced.  Reproducing those issues require the admin permission,
> though.
> 
> Changes from RFC v3
> - RFC v3: https://lore.kernel.org/20260610011420.3018-1-sj@xxxxxxxxxx
> - Add damon_Call() failure handling fixes for wsse and prcl.
> Changes from RFC v2
> - RFC v2: https://lore.kernel.org/20260609142119.68120-1-sj@xxxxxxxxxx
> - Add damon_start() failure handling fixes for wsse and prcl.
> Changes from RFC v1
> - RFC v1: https://lore.kernel.org/20260609005443.2122-1-sj@xxxxxxxxxx
> - Add damon_stop() failure handling fix to the series.
> 
> SeongJae Park (6):
>   samples/damon/wsse: handle damon_start() failure
>   samples/damon/prcl: handle damon_start() failure
>   samples/damon/mtier: handle damon_start() failure
>   samples/damon/mtier: handle damon_stop() failure
>   samples/damon/wsse: stop and free damon ctx when damon_call() fails
>   samples/damon/prcl: stop and free damon ctx when damon_call() fails
> 
>  samples/damon/mtier.c | 14 ++++++++++++--
>  samples/damon/prcl.c  | 11 +++++++++--
>  samples/damon/wsse.c  | 11 +++++++++--
>  3 files changed, 30 insertions(+), 6 deletions(-)

Looks good,

Reviewed-by: Zenghui Yu <zenghui.yu@xxxxxxxxx>

Thanks,
Zenghui