Re: [PATCH] staging: greybus: audio: add missing newline to sysfs_emit formats

[Brock Haftner]

On Sat, Jun 13, 2026 at 09:17:08AM +0300, Dan Carpenter wrote:
> On Sat, Jun 13, 2026 at 09:15:08AM +0300, Dan Carpenter wrote:
> > On Fri, Jun 12, 2026 at 06:49:05PM -0700, Brock Haftner wrote:
> > > The sysfs_emit() function is used to format strings that are returned
> > > to userspace. According to the sysfs documentation, these outputs
> > > should include a newline character for visual clarity.
> > >
> > > Fix the checkpatch.pl warnings by adding the missing '\n' to the
> > > sysfs_emit() format strings inside several functions.
> > >
> > > Signed-off-by: Brock Haftner <brockhaftner@xxxxxxxxx>
> >
> > Please don't do this for existing code, only for new code.  There
> > is a risck that user space relies on the old behavior.
>
> We should delete this checkpatch warning really.  It could be a
> sashiko rule which only applies for patches which introduce new
> functions or something.

Thank you for the explanation, apologies for the mistake. I did not
consider user-space implications for adding the newline characters.
I will drop this patch, thank you for the reply.

Cheers,
Brock


On Fri, Jun 12, 2026 at 11:17 PM Dan Carpenter <error27@xxxxxxxxx> wrote:
>
> On Sat, Jun 13, 2026 at 09:15:08AM +0300, Dan Carpenter wrote:
> > On Fri, Jun 12, 2026 at 06:49:05PM -0700, Brock Haftner wrote:
> > > The sysfs_emit() function is used to format strings that are returned
> > > to userspace. According to the sysfs documentation, these outputs
> > > should include a newline character for visual clarity.
> > >
> > > Fix the checkpatch.pl warnings by adding the missing '\n' to the
> > > sysfs_emit() format strings inside several functions.
> > >
> > > Signed-off-by: Brock Haftner <brockhaftner@xxxxxxxxx>
> >
> > Please don't do this for existing code, only for new code.  There
> > is a risck that user space relies on the old behavior.
>
> We should delete this checkpatch warning really.  It could be a
> sashiko rule which only applies for patches which introduce new
> functions or something.
>
> regards,
> dan carpenter
>