Re: [RFC PATCH 10/15] x86/tdx: Move and rename Quote request structure

[Peter Fang]

On Fri, Jun 12, 2026 at 05:04:05PM -0700, Dan Williams (nvidia) wrote:
> >  }
> >  #endif /* CONFIG_INTEL_TDX_GUEST && CONFIG_KVM_GUEST */
> >  
> > +#if defined(CONFIG_INTEL_TDX_GUEST) || defined(CONFIG_KVM_INTEL_TDX)
> > +/* struct tdx_quote_req: Format of Quote request message.
> > + * @version: Quote format version, filled by TD.
> > + * @status: Status code of Quote request, filled by VMM.
> > + * @in_len: Length of TDREPORT, filled by TD.
> > + * @out_len: Length of Quote data, filled by VMM.
> > + * @data: Quote data on output or TDREPORT on input.
> > + *
> > + * More details of Quote request message can be found in TDX
> > + * Guest-Host Communication Interface (GHCI) for Intel TDX 1.0,
> > + * section titled "TDG.VP.VMCALL<GetQuote>"
> > + */
> > +struct tdx_quote_req {
> > +	u64 version;
> > +	u64 status;
> > +	u32 in_len;
> > +	u32 out_len;
> > +	u8 data[];
> > +};
> > +#endif /* CONFIG_INTEL_TDX_GUEST || CONFIG_KVM_INTEL_TDX */
> 
> Drop the ifdef guards.
> 
> There is no cost to allowing a data structure to be defined
> unconditionally. Usually the ifdef guards are to prevent compilation
> errors when symbols do not resolve.
> 
> Otherwise looks ok.
> 
> Reviewed-by: Dan Williams <djbw@xxxxxxxxxx>

Will do, thanks for the review Dan!