Re: [PATCH v1 3/4] iio: pressure: mpl115: fix runtime PM leak on read error

[Jonathan Cameron]

On Sun, 14 Jun 2026 12:45:48 +0530
Biren Pandya <birenpandya@xxxxxxxxx> wrote:

> mpl115_read_raw() takes a runtime PM reference with pm_runtime_get_sync()
> before reading the processed pressure or raw temperature, but on the read
> error path it returns without calling pm_runtime_put_autosuspend(). Each
> failed read therefore leaks a runtime PM reference and prevents the device
> from autosuspending.
> 
> Drop the reference before checking the return value so both the success
> and error paths are balanced.
> 
> Signed-off-by: Biren Pandya <birenpandya@xxxxxxxxx>
> Assisted-by: Claude:claude-opus-4-8 coccinelle
Applied and marked for stable.
Thanks,

Jonathan

> ---
>  drivers/iio/pressure/mpl115.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/pressure/mpl115.c b/drivers/iio/pressure/mpl115.c
> index 830a5065c008..16e112b796ba 100644
> --- a/drivers/iio/pressure/mpl115.c
> +++ b/drivers/iio/pressure/mpl115.c
> @@ -106,18 +106,18 @@ static int mpl115_read_raw(struct iio_dev *indio_dev,
>  	case IIO_CHAN_INFO_PROCESSED:
>  		pm_runtime_get_sync(data->dev);
>  		ret = mpl115_comp_pressure(data, val, val2);
> +		pm_runtime_put_autosuspend(data->dev);
>  		if (ret < 0)
>  			return ret;
> -		pm_runtime_put_autosuspend(data->dev);
>  
>  		return IIO_VAL_INT_PLUS_MICRO;
>  	case IIO_CHAN_INFO_RAW:
>  		pm_runtime_get_sync(data->dev);
>  		/* temperature -5.35 C / LSB, 472 LSB is 25 C */
>  		ret = mpl115_read_temp(data);
> +		pm_runtime_put_autosuspend(data->dev);
>  		if (ret < 0)
>  			return ret;
> -		pm_runtime_put_autosuspend(data->dev);
>  		*val = ret >> 6;
>  
>  		return IIO_VAL_INT;