Re: [PATCH 2/5] iio: adc: Add ti-ads1262 driver

[Jonathan Cameron]

> > +
> > +DEFINE_RUNTIME_DEV_PM_OPS(ads1262_runtime_pm, ads1262_runtime_suspend,
> > +			  ads1262_runtime_resume, NULL);
> > +
> > +static const struct of_device_id ads1262_of_match[] = {
> > +	{ .compatible = "ti,ads1262" },
> > +	{ .compatible = "ti,ads1263" },  
> 
> So devices are fully compatible? Then it should be expressed in the
> binding and drop one entry here.

They aren't. It's relying on one of them having a subnode that spins up an
auxdev for the hardware block they don't share.  A fallback would be fine
but (to the device that has the more minimal feature set). I'd prefer the
driver to have a check on whether the subnode is allowed before blindly
registering it.

Jonathan


> 
> Best regards,
> Krzysztof
>