Re: [PATCH v4 02/30] KVM: x86: Move get_segment_base() to regs.h, as kvm_get_segment_base()

[Huang, Kai]

On Fri, 2026-06-12 at 17:03 -0700, Sean Christopherson wrote:
> Move get_segment_base() to regs.h, as kvm_get_segment_base(), so that the
> bulk of the register code can be moved from x86.c to a new regs.c, without
> simultaneously needing to rename "public" helpers to explicitly scope them
> to KVM.
> 
> No functional change intended.
> 
> Cc: Yosry Ahmed <yosry@xxxxxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Reviewed-by: Kai Huang <kai.huang@xxxxxxxxx>

Nit of nit: maybe explicitly say emulator_get_cached_segment_base() in x86.c
still calls kvm_get_segment_base() after code movement, so the change here is
more obvious.