RE: [PATCH v7 2/2] rtc: Add NXP PCF85053 driver support

[Lakshay Piplani]

> -----Original Message-----
> From: Lakshay Piplani <lakshay.piplani@xxxxxxx>
> Sent: Thursday, November 27, 2025 5:35 PM
> To: alexandre.belloni@xxxxxxxxxxx; linux-rtc@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Cc: Vikash Bansal <vikash.bansal@xxxxxxx>; Priyanka Jain
> <priyanka.jain@xxxxxxx>; Shashank Rebbapragada
> <shashank.rebbapragada@xxxxxxx>; Lakshay Piplani
> <lakshay.piplani@xxxxxxx>; Daniel Aguirre <daniel.aguirre@xxxxxxx>; Pankit
> Garg <pankit.garg@xxxxxxx>
> Subject: [PATCH v7 2/2] rtc: Add NXP PCF85053 driver support
> 
> PCF85053 is i2c based RTC which supports timer and calendar functionality.
> 
> Features supported:
> 1. Read/Write time
> 2. Get/Set Alarm
> 3. Wakeup Source
> 4. Generate up to 32768Hz clock output
> 5. Primary/Secondary i2c bus
> 
> Signed-off-by: Daniel Aguirre <daniel.aguirre@xxxxxxx>
> Signed-off-by: Pankit Garg <pankit.garg@xxxxxxx>
> Signed-off-by: Lakshay Piplani <lakshay.piplani@xxxxxxx>
> ---
> V6 -> V7: - Addressed minor cleanups from review: use
> dev_get_drvdata()/dev_set_drvdata()
> 	    consistently, fix alarm IRQ dev_id handling, and switch to
> devm_device_init_wakeup().
> 	  - Simplified time/alarm programming by forcing 24h + binary mode in
> hardware,
> 	    dropping complex 12h/BCD handling in setters.
> 	  - Documented the 2000–2099 supported year range, explaining how
> the 00–99 year
> 	    register maps to leap-year behavior in the device.
> V5 -> V6: no changes
> V4 -> V5: no changes
> V3 -> V4: - Handle multi-host ownership explicitly using primary/secondary bus
> hadling.
>           - Probe no longer changes any CTRL bits unconditionally and do not clear
> ST/AF/OF
>             avoiding lost interrupts or silent mode changes.
>           - Read/Set time & alarm now respect HF(12/24h) and DM(BCD/BIN)
> converting
>             hour fields correctly for all combinations.
>           - Minor changes: drop noisy warnings, tidy error paths/comments.
> V2 -> V3: Add MAINTAINERS file changes to this patch
> V1 -> V2: no changes

Hi,

I wanted to follow up again on the patch series I submitted in November 2025
(v7 of the PCF85053 RTC driver). I haven’t received any feedback on it so far,
so, I wanted to check if you’ve had a chance to review it.

I understand things can get busy, but I would really appreciate any feedback
when you get the time. Please let me know if any additional information is needed from my side.

Thanks for your time.

Best regards,
Lakshay Piplani