Re: [PATCH] staging: fbtft: use %pe for backlight errors
From: Andy Shevchenko
Date: Mon Jun 15 2026 - 03:10:46 EST
On Sun, Jun 14, 2026 at 11:08 PM Keefe Reeves <reeveskeefe@xxxxxxxxx> wrote:
>
> From: Keefe Reeves <229415268+reeveskeefe@xxxxxxxxxxxxxxxxxxxxxxxx>
>
> Coccinelle found two places where backlight registration errors are
> printed by passing PTR_ERR() to dev_err().
>
> Use %pe instead so the error pointer can be printed directly. This keeps
> the behavior the same and just makes the error printing cleaner.
>
> Signed-off-by: Keefe Reeves <229415268+reeveskeefe@xxxxxxxxxxxxxxxxxxxxxxxx>
I see a subtle problem with this email address. In case something
happened with your contribution (exempli gratia a regression found)
there will be no possibility to contact you without digging into
mailing list archives to get your Gmail address. I would prefer to see
the From: and SoB to acce-pt responses.
For the change itself, I have no objections. If one considers this
useful (probably to stop flood of the similar patches in the future)
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko