RE: [PATCH 01/11] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support

[Biju Das]

Hi Krzysztof Kozlowski,

Thanks for the feedback.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 13 June 2026 11:40
> Subject: Re: [PATCH 01/11] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support
> 
> On Fri, Jun 12, 2026 at 03:30:29PM +0100, Biju wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Add device tree binding support for the RZ/G3L (r9a08g046) USB PHY
> > controller. The RZ/G3L USB PHY block is similar to RZ/G3S, but each
> > port has an OTG controller, unlike RZ/G3S, which has an OTG controller
> > only on port 1.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> >  .../reset/renesas,rzg2l-usbphy-ctrl.yaml      | 20 ++++++++++++++++++-
> >  1 file changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.ya
> > ml
> > b/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.ya
> > ml index c83469a1b379..788e467b38db 100644
> > ---
> > a/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.ya
> > ml
> > +++ b/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctr
> > +++ l.yaml
> > @@ -23,6 +23,7 @@ properties:
> >                - renesas,r9a07g054-usbphy-ctrl # RZ/V2L
> >            - const: renesas,rzg2l-usbphy-ctrl
> >        - const: renesas,r9a08g045-usbphy-ctrl # RZ/G3S
> > +      - const: renesas,r9a08g046-usbphy-ctrl # RZ/G3L
> 
> These last two should be just enum, by convention.

OK.
> 
> >
> >    reg:
> >      maxItems: 1
> > @@ -50,6 +51,12 @@ properties:
> >      $ref: /schemas/regulator/regulator.yaml#
> >      unevaluatedProperties: false
> >
> > +  regulator1-vbus:
> > +    type: object
> > +    description: Port 2 USB VBUS regulator
> > +    $ref: /schemas/regulator/regulator.yaml#
> > +    unevaluatedProperties: false
> 
> Instead group them under 'regulators' node and use names matching the datasheet.

OK. Will use vbus0 and vbus1 for these regulators.

> 
> > +
> >    renesas,sysc-pwrrdy:
> >      description:
> >        The system controller PWRRDY indicates to the USB PHY if the
> > power supply @@ -78,7 +85,9 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: renesas,r9a08g045-usbphy-ctrl
> > +            enum:
> > +              - renesas,r9a08g045-usbphy-ctrl
> > +              - renesas,r9a08g046-usbphy-ctrl
> >      then:
> >        required:
> >          - renesas,sysc-pwrrdy
> > @@ -86,6 +95,15 @@ allOf:
> >        properties:
> >          renesas,sysc-pwrrdy: false
> >
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: renesas,r9a08g046-usbphy-ctrl
> > +    then:
> > +      required:
> > +        - regulator1-vbus
> 
> else:
>   properties:
>     regulators: false

Agreed.

Cheers,
Biju