Re: [PATCH v3 03/10] dt-bindings: input: microchip,cap11xx: Update datasheet URL and LED reg range

[Conor Dooley]

On Mon, Jun 15, 2026 at 10:20:29PM +0800, Jun Yan wrote:
> - Add datasheet links for all supported CAP11xx variants.
> - Update LED node regex and replace enum constraints with minimum/maximum
>   for LED reg ranges in preparation for CAP1114 support.
> 
> CAP1114 has 11 LED channels. minimum/maximum constraints are easier to
> maintain than long enum lists when expanding channel count later.
> 
> Signed-off-by: Jun Yan <jerrysteve1101@xxxxxxxxx>
> ---
>  .../bindings/input/microchip,cap11xx.yaml       | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> index 7ade03f1b32b..9578c7c206a2 100644
> --- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> +++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> @@ -10,6 +10,15 @@ description: |
>    The Microchip CAP1xxx Family of RightTouchTM multiple-channel capacitive
>    touch controllers and LED drivers. The device communication via I2C only.
>  
> +  For more product information please see the links below:
> +    CAP1106: https://ww1.microchip.com/downloads/en/DeviceDoc/00001624B.pdf
> +    CAP1126: https://ww1.microchip.com/downloads/en/DeviceDoc/00001623B.pdf
> +    CAP1188: https://ww1.microchip.com/downloads/en/DeviceDoc/00001620C.pdf
> +    CAP1203: https://ww1.microchip.com/downloads/en/DeviceDoc/00001572B.pdf
> +    CAP1206: https://ww1.microchip.com/downloads/en/DeviceDoc/00001567B.pdf
> +    CAP1293: https://ww1.microchip.com/downloads/en/DeviceDoc/00001566B.pdf
> +    CAP1298: https://ww1.microchip.com/downloads/en/DeviceDoc/00001571B.pdf
> +
>  maintainers:
>    - Rob Herring <robh@xxxxxxxxxx>
>  
> @@ -124,14 +133,16 @@ properties:
>        The number of entries must correspond to the number of channels.
>  
>  patternProperties:
> -  "^led@[0-7]$":
> +  "^led@[0-9a-f]$":

This should be done alongside the cap1114 change, not here I think. The
constraint relaxation doesn't make sense because the user is arriving in
a later patch.
With it moved,
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Although, should it not be led@[0-9a-b] if the max is 11?

pw-bot: changes-requested

Cheers,
Conor.

>      type: object
>      description: CAP11xx LEDs
>      $ref: /schemas/leds/common.yaml#
>  
>      properties:
>        reg:
> -        enum: [0, 1, 2, 3, 4, 5, 6, 7]
> +        description: LED channel number
> +        minimum: 0
> +        maximum: 7
>  
>        label: true
>  
> @@ -158,7 +169,7 @@ allOf:
>                - microchip,cap1298
>      then:
>        patternProperties:
> -        "^led@[0-7]$": false
> +        "^led@": false
>  
>    - if:
>        properties:
> -- 
> 2.54.0
>

Attachment: signature.asc
Description: PGP signature