Re: [PATCH v3 3/3] regulator: qcom-refgen: add support for the IPQ9650 SoC
From: Kathiravan Thirumoorthy
Date: Mon Jun 15 2026 - 13:40:30 EST
On 6/15/2026 11:01 PM, Mark Brown wrote:
On Mon, Jun 15, 2026 at 10:54:26PM +0530, Kathiravan Thirumoorthy wrote:
On 6/15/2026 9:28 PM, Mark Brown wrote:Yes. If as it seems the device can actually implement a get_status()
This looks like a get_status() operation, not an enable operation? TheThanks, Mark for the review. If I understand correctly, I should track the
enables and disables are pure clock operations.
clock enable/disable operations and return that state in the is_enabled()
callback (as I did in v1). Please let me know if my understanding does not
align with your expectations.
operation the driver should do that as well.
Thanks Mark. I shall introduce get_status() with STATUS register read back and update the is_enabled() to track the clock enable / disable operation.